Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glfw: export Drop callback #145

Merged
merged 6 commits into from
May 2, 2023
Merged

glfw: export Drop callback #145

merged 6 commits into from
May 2, 2023

Conversation

gucio321
Copy link
Collaborator

fix #123
This adds SetDropCallback function

CC @SeyRyuu

@gucio321 gucio321 marked this pull request as ready for review April 24, 2023 09:02
@gucio321
Copy link
Collaborator Author

idk why, bu this is built from #138 . As the other PR seems to be merged soon, I'll not rebase this. Instead I'll mark as draft until the other pr gets merged.

@gucio321 gucio321 marked this pull request as draft April 25, 2023 15:12
@gucio321 gucio321 marked this pull request as ready for review May 2, 2023 14:23
@gucio321
Copy link
Collaborator Author

gucio321 commented May 2, 2023

now it is ready

AllenDang
AllenDang approved these changes May 2, 2023
View reviewed changes
Copy link
Owner

@AllenDang AllenDang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllenDang AllenDang merged commit 97518c1 into AllenDang:main May 2, 2023
@gucio321 gucio321 mentioned this pull request Jul 14, 2023
Merged
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenDang AllenDang AllenDang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use the "onDrop of external files" example from giu in cimgui-go?
2 participants
@gucio321 @AllenDang